search

a14n / dart-js-wrapping

With that package you will be able to easilly wrap JS library in Dart.
https://pub.dartlang.org/packages/js_wrapping
Other
43 stars 16 forks source link

fixed mappedBy -> map #1

Closed Gubaer closed 11 years ago

Gubaer commented 11 years ago

Regards Karl

a14n commented 11 years ago

Thanks for your PR.

I was waiting for dart-lang/js-interop#47 to commit local modifications on code. I am not sure this repository will stay alive because I hope to move part of it into js-interop... But for now, it is usable :)

Gubaer commented 11 years ago

The problem is, that http://pub.dartlang.org/packages/google_maps comes with its own js_wrap.dart which is outdaten.

The version of google_maps pub pulls in if sees the dependency

dependencies:
  google_maps: ">=1.1.2 <2.0.0"

also has mappedBy invocations on Lists.

Could you please update js_wrap.dart in google_maps and publish a new version on pub.dartlang.org?

Thanks in advance!

a14n commented 11 years ago

@Gubaer Thanks for pointing this. I just uploaded a 1.1.3 version of google_maps to fix that issue. It should be OK.

Gubaer commented 11 years ago

thanks!