search

a14n / dart-js-wrapping

With that package you will be able to easilly wrap JS library in Dart.
https://pub.dartlang.org/packages/js_wrapping
Other
43 stars 16 forks source link

Package's tests fail with Dart2-compliant DDC #21

Open matanlurey opened 6 years ago

matanlurey commented 6 years ago 
CastError: Casting value of type 'JsArray' to type 'Iterable<String>' which is incompatible in strong mode
dart:_runtime              as_C
browser_tests.dart 258:21  test$.test.dart.fn

CastError: Casting value of type 'JsArray' to type 'Iterable<String>' which is incompatible in strong mode
dart:collection            get length
browser_tests.dart 283:15  test$.test.dart.fn

CastError: Casting value of type 'JsArray' to type 'Iterable<String>' which is incompatible in strong mode
dart:collection            get length
browser_tests.dart 294:15  test$.test.dart.fn

CastError: Casting value of type 'JsArray' to type 'Iterable<String>' which is incompatible in strong mode
dart:collection            toString
browser_tests.dart 307:23  test$.test.dart.fn
a14n commented 6 years ago

I don't know how to reproduce that but it may be fixed by #20.

matanlurey commented 6 years ago

Sounds like it. Maybe we should start testing with DDC/Dart2?

You can see an example in pkg/mockito, using build_runner:

matanlurey commented 6 years ago

Can we release with #20 so @munificent can land it internally?

a14n commented 6 years ago

0.4.3 released

munificent commented 6 years ago

Thanks, @a14n! 😀