a16z / halmos

A symbolic testing tool for EVM smart contracts
GNU Affero General Public License v3.0
817 stars 68 forks source link

ci: disable pytest-xdist #345

Closed daejunpark closed 3 months ago

daejunpark commented 3 months ago

The ci test workflow was updated to use a single worker with pytest -n 1 in #336. However, flakiness issues persist, so let's try disabling the xdist plugin altogether.

Additionally, xdist workers crash when --cache-solver enabled. Now that xdist is disabled, tests using --cache-solver have also been added.

karmacoma-eth commented 3 months ago

ah really? darn

Do you remember what error they failed with?

anyway happy to give this a try

daejunpark commented 3 months ago

Do you remember what error they failed with?

i don't remember exactly, (though i could check the old gh action logs), but i believe it was segfault due to race conditions caused by multiple workers.