Closed sragss closed 7 months ago
~Still need to pull packed_flags
out of bytecode_v
and resolve with upstream.~ Handled.
There is also a tight relationship between R1CSInputs::clone_to_stepwise
/ R1CSInputs::clone_to_trace_len_chunks
/ R1CSProof::format_commitments
now that should be enshrined either through collocation or a unit test. Plus likely some wiki documentation.
The circuit accepts commitments / witness segments of length
padded_trace_len
in the following format:This PR makes this explicit through the use of wrapper types
R1CSInputs
which will transform to the relevant shapes withinsnark.rs
. Additionally this pulls the commitments exclusively used by R1CS out intoR1CSUniqueCommitments
and formats the existingJoltCommitments
withR1CSUniqueCommitments
usingR1CSProof::format_commitments(...)
.