search

a16z / jolt

The simplest and most extensible zkVM. Fast and fully open source from a16z crypto and friends. ⚡
https://jolt.a16zcrypto.com
MIT License
619 stars 123 forks source link

feat(jolt-core): Adding new multiplication instructions #303

Closed mw2000 closed 3 months ago

mw2000 commented 4 months ago

Jolt will now support some multiplication instructions - MUL, MULU for the RISC-V M extension.

Addresses parts of #251

mw2000 commented 3 months ago

Hey @moodlezoup this PR should be ready for review now. I originally planned to include the MULHU instruction in this as well, but was failing at implementing it (skill issue).

I based the MUL, and MULU instructions closely off what we have for the ADD and SUB instructions, would love to know if this approach makes sense or if I should modify to have a custom sub-table for this.

mw2000 commented 3 months ago

Appreciate the direction setting on this in DMs moodlezoup, got the MULHU instruction to work :)