a16z / jolt

The simplest and most extensible zkVM. Fast and fully open source from a16z crypto and friends. ⚡
https://jolt.a16zcrypto.com
MIT License
655 stars 137 forks source link

Refactor `EqPolynomial::evals` #351

Closed moodlezoup closed 4 months ago

moodlezoup commented 5 months ago

https://github.com/a16z/jolt/blob/main/jolt-core/src/poly/eq_poly.rs

Currently the function signature is pub fn evals(&self) -> Vec<F> If we change this to pub fn evals(r: &[F]) -> Vec<F>, we should be able to avoid some unnecessary cloning throughout the codebase.

SuccinctPaul commented 4 months ago

hi, @moodlezoup , I've submitted a pr. Please review

moodlezoup commented 4 months ago

355