search

a16z / jolt

The simplest and most extensible zkVM. Fast and fully open source from a16z crypto and friends. âš¡
https://jolt.a16zcrypto.com
MIT License
580 stars 105 forks source link

fib_e2e: Actually use the type parameters 🙃 #392

Closed imikushin closed 2 weeks ago

imikushin commented 3 weeks ago

fib_e2e is parameterized with <F: JoltField, PCS: CommitmentScheme<Field = F>>, but is currently using a concrete field and commitment scheme instead of them:

let (proof, commitments) =
    <RV32IJoltVM as Jolt<Fr, HyraxScheme<G1Projective>, C, M>>::prove(
        io_device,
        trace,
        circuit_flags,
        preprocessing.clone(),
    );

Given there are multiple tests calling fib_e2e with different implementations of JoltField and CommitmentScheme, this is probably not intended.

imikushin commented 3 weeks ago

cargo nextest run -p jolt-core succeeded locally. Test fails due to #376