a1ive / grub2-filemanager

GRUB2-based file manager
https://a1ive.github.io/grub2-filemanager/
GNU General Public License v3.0
527 stars 106 forks source link

Hebrew is not fully RTL #64

Open yarons opened 4 years ago

yarons commented 4 years ago

The options on the main screen should be aligned to the right, as you can see the F1/F2/etc. appear to the left while these should be on the right and the line is aligned to the left instead of the right.

Screen Shot 2019-12-23 at 14 48 16

Well the text appears correctly but the lines should be aligned from right to left meaning that the line should start with the icon to the right and then the text.

Screen Shot 2019-12-23 at 14 49 25

Furthermore the text is considered LTR (this is why the F1 is on the left), just to give a quick example with the translation of GRUB is wonderful in Hebrew:

Wrong: GRUB זה נפלא!

Correct (Aligned to the right and the string beginning with GRUB):

GRUB זה נפלא!

a1ive commented 4 years ago

It seems that GRUB 2 don't support RTL languages. I will try to fix it. According to GRUB Manual (https://www.gnu.org/software/grub/manual/grub/grub.html)

16.2.4 terminfo Command: terminfo [-a|-u|-v] [term] Define the capabilities of your terminal by giving the name of an entry in the terminfo database, which should correspond roughly to a ‘TERM’ environment variable in Unix. The currently available terminal types are ‘vt100’, ‘vt100-color’, ‘ieee1275’, and ‘dumb’. If you need other terminal types, please contact us to discuss the best way to include support for these in GRUB. The -a (--ascii), -u (--utf8), and -v (--visual-utf8) options control how non-ASCII text is displayed. -a specifies an ASCII-only terminal; -u specifies logically-ordered UTF-8; and -v specifies "visually-ordered UTF-8" (in other words, arranged such that a terminal emulator without bidirectional text support will display right-to-left text in the proper order; this is not really proper UTF-8, but a workaround). If no option or terminal type is specified, the current terminal type is printed.

yarons commented 4 years ago

Cool, thank you so much!

BTW the info you sent is about the order of the characters, this is absolutely fine in our case, the problem is the surrounding environment.