Closed hillerstorm closed 8 years ago
Ah, that's annoying. Thanks for adding, and nice tests! I am gonna have dinner and take a closer look.
My only concern is that it's an infinite loop if the song has length 0, but it might bail out earlier in that case. Not sure.
This makes sense and looks good. Would you mind adding a test for the song_looppos logic?
Sure, I'll add a test or two and rebase
Awesome. Thanks!
Tested against remember_by_stalker_offyllecell303.xm.
The pattern at the last song position in
player.xm.songpats
is26
which doesn't exist inplayer.xm.patterns
. This causesp
in the following line to returnundefined
resulting in multiple errors being logged:To jump to the last pattern instantly set a breakpoint in
xm.js:play()
, run the following code in the debugger and then resume: