a1k0n / jsxm

FastTracker 2 .xm module player in Javascript
http://www.a1k0n.net/code/jsxm/
MIT License
485 stars 36 forks source link

Implement Gxx effect #12

Closed hillerstorm closed 8 years ago

hillerstorm commented 8 years ago

Tested against remember_by_stalker_offyllecell303.xm.

The effect is in use in the last two patterns, col 6.

To jump there instantly set a breakpoint in xm.js:play(), run the following code in the debugger and then resume:

player.cur_songpos=28;player.cur_pat=24;player.cur_row=0

A PR to fix the errors being logged to the console at the end of the file above has been filed here: #11

hillerstorm commented 8 years ago

I guess there's an implicit "bug" with this effect when looping the song from the beginning if the last row before the end has changed the volume. This is a feature more than a bug though since it can be used for other loops where playing at a lower volume is wanted.

hillerstorm commented 8 years ago

Rebasing this again after the added Axx-test :)

a1k0n commented 8 years ago

oh sorry, I was just fixing that myself. thanks. :)

a1k0n commented 8 years ago

I merged manually. Next time I will double-check the pull requests before hacking.

Thanks again, this is great!

hillerstorm commented 8 years ago

:) my pleasure! It's fun watching the project grow