Bug: 300 / M0 means "use last value" not a literal zero

a1k0n / jsxm

FastTracker 2 .xm module player in Javascript

http://www.a1k0n.net/code/jsxm/

MIT License

485 stars 36 forks source link

Bug: 300 / M0 means "use last value" not a literal zero #24

Closed Broam closed 8 years ago

Broam commented 8 years ago

Channel zero of this song - the Moog sample should continue w/ the tone portamento (3xx / Mx in volume column) instead of restarting, but the effect is unimplemented.

Broam_-_FSharp_Jump.xm.zip

Song's CC-By-SA, as noted in the sample text

a1k0n commented 8 years ago

Thanks for the report!

Just pushed a fix... Now you can actually hear the filter sweep in the song. Will update my site later tonight.

a1k0n commented 8 years ago

FWIW, 300 was implemented correctly, but Mx wasn't implemented at all.

a1k0n commented 8 years ago

Fixed on https://www.a1k0n.net/code/jsxm/

Thanks for the report.

a1k0n commented 8 years ago

However the Lxx effect isn't implemented; I believe your song uses it heavily. See #5