a1k0n / jsxm

FastTracker 2 .xm module player in Javascript
http://www.a1k0n.net/code/jsxm/
MIT License
485 stars 36 forks source link

Adding the missing effects. #5

Open luckcolors opened 8 years ago

luckcolors commented 8 years ago

Hello. I really like this project :) and i hope in the future there will be support for all the xm effects.

a1k0n commented 8 years ago

Yep, I was looking at it this morning. The rest shouldn't be too difficult to add; some are fairly tricky like note delay (I am liable to break corner cases of portamento in the process) so I'd like to throw a bunch of tests in first.

I'll enumerate the currently missing effects here (using OpenMPT's guide):

Effect column:

Volume column:

The effects are implemented in a table in xmeffects.js and anything marked "easy" above can probably be implemented completely within that file. Pull requests appreciated.

a1k0n commented 8 years ago

Gxx done, thanks @hillerstorm!