Namespacing and global leakage

a1k0n / jsxm

FastTracker 2 .xm module player in Javascript

http://www.a1k0n.net/code/jsxm/

MIT License

485 stars 36 forks source link

Closed hillerstorm closed 8 years ago

hillerstorm commented 8 years ago

Would at least be a start towards closing #2 :)

Wrapped everything up and exposed only the shared functions and variables in a global object on window.

a1k0n commented 8 years ago

Wow, this is great! Thanks for cleaning this mess up!

a1k0n commented 8 years ago

Looks good. If you're happy with it now, I'll merge.

hillerstorm commented 8 years ago

:shipit: :+1:

a1k0n commented 8 years ago

Thanks again!

tibbon commented 8 years ago

Nice work!