search

a2-4am / 4cade

100s of games at your fingertips, as long as your fingertips are on an Apple ][
https://archive.org/details/TotalReplay
MIT License
153 stars 22 forks source link

Fix PoP keyboard control #541

Closed roughana closed 1 year ago

roughana commented 1 year ago

The issue is identified & documented here with video evidence https://www.applefritter.com/comment/101047#comment-101047 TR's PoP exhibits the problem on my Platinum //e.

I believe the OP is referring to published PoP source code. Search for the KEYS routine which includes the following: LDA $C000 STA keypress LDA $C010 STA keydown JSR KREAD

Unfortunately, a full solution is not available at the link, only a description of the problem and a suggested solution:

"The ideal fix would replace [LDA $C010, STA keydown] with a test of the previously-saved AnyKeyDown state, and a branch to skip the LDA $C010 in the case when the previous AnyKeyDown indicated all keys had been released, plus a test LDA $C000 to resume normal activity after the next KEYSTROBE."

peterferrie commented 1 year ago

fixed in dbd77dc70533452206cf80761ef0d67c17b1a7a5