a2 / MessagePack.swift

It's like JSON, but fast and small…and Swift! – msgpack.org[Swift]
http://msgpack.org
MIT License
283 stars 60 forks source link

Integer overflow build Errors in XCode 9 Beta 5 #52

Closed litso closed 7 years ago

litso commented 7 years ago

In Pack.swift: packPositiveInteger and Pack.swift: packwe get the following errors when comparing either UInt64 or UInt32 values to 0xffff_ffff

Integer literal '4294967295' overflows when stored into 'Int'

and

Integer literal '4294967295' overflows when stored into signed 'Builtin.Int32'
litso commented 7 years ago

This appears to be related to 32-bit/64-bit support. https://stackoverflow.com/questions/35329459/integer-literal-overflows-when-stored-into-int

Do we plan on supporting 32-bit platforms going forward?

a2 commented 7 years ago

@litso, great catch on the Xcode 9 support bug, and thanks for your contributions 😄