a2 / MessagePack.swift

It's like JSON, but fast and small…and Swift! – msgpack.org[Swift]
http://msgpack.org
MIT License
283 stars 60 forks source link

Spec version? #68

Closed iwasrobbed-ks closed 5 years ago

iwasrobbed-ks commented 5 years ago

Hi there 👋 Does this follow a specific version of the spec? e.g. https://github.com/msgpack/msgpack/blob/master/spec.md

Just wondering so we make sure our backend<>client teams use the same spec.

a2 commented 5 years ago

This is a good question! The spec does not really have version numbers, which is a problem. This repo doesn't support the timestamp extension, for example, which did not exist the last time I visited the spec. Do you have any ideas for best practices? Ideally we would be able to make sure your backend and client use the same spec.

iwasrobbed-ks commented 5 years ago

It looks like they are just using v2.0 for now: https://github.com/msgpack/msgpack/pull/165

Might be worth filing an issue with them to standardize around semantic versioning for all the incremental changes that have occurred after 2.0 was released

iwasrobbed-ks commented 5 years ago

Actually, looks like there's up to a v5 at this point: https://github.com/msgpack/msgpack/issues/195

It looks like all changes have been additive up until this point (but does that include bug fixes?) https://github.com/msgpack/msgpack/issues/195#issuecomment-91518024

iwasrobbed-ks commented 5 years ago

Going to close this out. Just wanted to say thanks for your great work on this. It's a very clean API and well tested which makes our lives easy 💯