search

a2800276 / 8583

ruby implementation of iso 8583 financial messages
http://www.kuriositaet.de
MIT License
41 stars 44 forks source link

Cleanup #1

Closed ta closed 12 years ago

ta commented 12 years ago

I've done some cleaning up in the code including:

There are no functional changes

a2800276 commented 12 years ago

Hi Tonni!

Thanks very much for the pull. Just out of curiosity: is there any reason to move 8583 to iso8583? Does this conflict with anything? I'd rather not move stuff around for purely aesthetic reasons...

ta commented 12 years ago

Hi,

The move from 8385 to iso8583 is mainly motivated by iso8583 being a - to my mind - more accurate term. Somehow I got the impression that the name "8583" was legacy and a move towards iso8583 was already in progress because of the fact that the gem is called "iso8583" and the file "lib/iso8583.rb". I guess its a misconception on my part - perhaps due to my pedantic side that somehow finds a name of pure numbers wrong :)

There is no functional changes, so in that way the change is only aesthetic. Would you like me to remove that change and perhaps create a new pull request?

a2800276 commented 12 years ago

don't worry about it. I think having better gemspecs is really worthwhile and I don't think it's worth the effort to pull everything apart to avoid the renames.