search

a2800276 / 8583

ruby implementation of iso 8583 financial messages
http://www.kuriositaet.de
MIT License
41 stars 44 forks source link

added a #to_hash method to the message class #12

Closed robfalken closed 9 years ago

robfalken commented 9 years ago

I added a #to_hash method that does what it sounds like, returning a hash representation of the message. It will use aliases for keys if defined, otherwise use the field name.

Didn't add tests though, because I couldn't manage to get the test suit to run.

Figured you guys might want it anyway, otherwise just throw it away.

a2800276 commented 9 years ago

Thanks very much for the contribution. I'm afraid I'll have to throw it away though. I don't have time to keep up with the latest ruby trend in testing. The tests work fine in 1.8 up to ??? but at some point someone decided to rename test/unit to mintest/unicorn/ninja and broke existing code.

Also, Rails 1.9 and up is no longer suitable for dealing with anything byte oriented.

I don't want to add features that aren't tested, so unless someone fixes stuff to work with more current rubies, this project is unfortunately abandoned for the moment. Sorry about that. I'll add an announcement to the README concerning the matter.

MaG21 commented 9 years ago

wow, really bad news.

@robertfalken may I use your code in my fork? -> https://github.com/MaG21/8583

I plan to fix the test suit, though it has the lowest priority for me right now. For testing I'm using a simple script in my projects and nothing more.

robfalken commented 9 years ago

@a2800276 got it.

@MaG21 I might switch to your fork instead if it's more active. You want me to PR to that one?

MaG21 commented 9 years ago

Please do, you're more than welcome.

My fork is not very active, but I do plan to maintain it.

a2800276 commented 9 years ago

Let me know if you need any help and when things are back to running and I'll be happy to merge things back :)

a2800276 commented 9 years ago

I see you made a couple of changes already, wasn't aware of your fork.

MaG21 commented 9 years ago

:)