search

a2lix / AutoFormBundle

Automate Symfony form building
https://a2lix.fr/bundles/auto-form
MIT License
83 stars 30 forks source link

Fix toOne translation fields #30

Closed jordisala1991 closed 2 years ago

jordisala1991 commented 2 years ago

Fixing the problem of #10

Also closes: #25 #13

jordisala1991 commented 2 years ago

@tchapi or @webda2l could you approve the workflow, so we can see what needs to be fixing on the test side?

webda2l commented 2 years ago

It's not that so simple as explained elsewhere https://github.com/a2lix/AutoFormBundle/pull/25#issuecomment-885229036 & https://github.com/a2lix/AutoFormBundle/pull/13#issuecomment-506905417

jordisala1991 commented 2 years ago

I just applied this to my project and it works like a charm, mind yo explain why it does not work?

(Im trying with ManyToOne, maybe the problem if it is ManyToMany?)

jordisala1991 commented 2 years ago

Let's start again, by adding a failing test... I'm trying to fix it but I always end up in a infinite loop

jordisala1991 commented 2 years ago

Can you take a look at the proposed solution? @webda2l

webda2l commented 2 years ago

Thanks @jordisala1991, I will check later this weekend with https://github.com/a2lix/AutoFormBundle/pull/10#issuecomment-407851110 to try to refresh my memory about this, but it's sound good :)