Closed adelinerobinet closed 2 years ago
I think the CI problem is not related to the PR changes
Hi @adelinerobinet and thanks a lot for this contribution.
Do you think you could also initiate macros_*
files for Bootstrap 4 and Bootstrap 5 including your changes now that these versions are supported ?
Hi @adelinerobinet and thanks a lot for this contribution.
Do you think you could also initiate
macros_*
files for Bootstrap 4 and Bootstrap 5 including your changes now that these versions are supported ?
@tchapi It's done ! :)
Merging #354 (6350814) into master (1afb2b9) will increase coverage by
4.85%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #354 +/- ##
============================================
+ Coverage 66.38% 71.23% +4.85%
+ Complexity 72 71 -1
============================================
Files 12 12
Lines 235 226 -9
============================================
+ Hits 156 161 +5
+ Misses 79 65 -14
Impacted Files | Coverage Δ | |
---|---|---|
src/Form/Type/TranslatedEntityType.php | 0.00% <0.00%> (ø) |
|
src/Form/Type/TranslationsLocalesSelectorType.php | 0.00% <0.00%> (ø) |
|
src/Form/Type/TranslationsType.php | 95.23% <0.00%> (+0.23%) |
:arrow_up: |
src/DependencyInjection/Configuration.php | 94.87% <0.00%> (+0.27%) |
:arrow_up: |
src/Form/Type/TranslationsFormsType.php | 92.00% <0.00%> (+0.69%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update adb5e5b...6350814. Read the comment docs.
@webda2l you can merge this one :)
Sure, thank you both!
With this example we have a conflict id on the tab :
With this PR, we no longer have the same id.