search

a2lix / TranslationFormBundle

Ease translations with some dedicated Symfony form types
https://a2lix.fr/bundles/translation-form
MIT License
330 stars 140 forks source link

Allow PHP8 in CI [WIP] #367

Closed tchapi closed 2 years ago

tchapi commented 2 years ago

Fixed

Allow PHP 8 for CI tests

codecov-commenter commented 2 years ago

Codecov Report

Merging #367 (6867fc5) into master (821ebd2) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #367   +/-   ##
=========================================
  Coverage     71.23%   71.23%           
  Complexity       71       71           
=========================================
  Files            12       12           
  Lines           226      226           
=========================================
  Hits            161      161           
  Misses           65       65

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 821ebd2...6867fc5. Read the comment docs.

tchapi commented 2 years ago

See https://github.com/KnpLabs/DoctrineBehaviors/releases — DoctrineBehaviors still support PHP 7.2 on the ^2.0 tags

tchapi commented 2 years ago

This should be a no-brainer, except the bump to ^2 for DoctrineBehaviors, but I think it's fine (tested on my side in PHP 8.0 and DoctrineBehaviors 2.5).

@webda2l I can merge now a priori, do you prefer squashing or rebasing (merge-commit is not enabled for this repo apparently)?

webda2l commented 2 years ago

👍 I used to do "squash & merge"