a2lix / TranslationFormBundle

Ease translations with some dedicated Symfony form types
https://a2lix.fr/bundles/translation-form
MIT License
330 stars 140 forks source link

php8 and php8.1 support #370

Closed wdrupal closed 2 years ago

wdrupal commented 2 years ago

As the package has Symfony 6 support it would be nice to have PHP ^8 support

  Problem 1
    - a2lix/auto-form-bundle[0.2, ..., 0.3] require php ^7.1.3 -> your php version (8.1.1) does not satisfy that requirement.
    - a2lix/auto-form-bundle 0.3.1 requires php ^7.2 -> your php version (8.1.1) does not satisfy that requirement.
    - a2lix/auto-form-bundle[0.3.2, ..., 0.3.3] require symfony/config ^3.4.30|^4.3|^5.0 -> found symfony/config[v3.4.30, ..., v3.4.47, v4.3.0, ..., v4.4.36, v5.0.0, ..., v5.4.2] but the package is fixed to v6.0.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    - a2lix/translation-form-bundle 3.1.0 requires a2lix/auto-form-bundle ^0.2|^0.3 -> satisfiable by a2lix/auto-form-bundle[0.2, ..., 0.3.3].
    - Root composer.json requires a2lix/translation-form-bundle ^3.1 -> satisfiable by a2lix/translation-form-bundle[3.1.0].
tchapi commented 2 years ago

Hi

Thanks for the report. From what I understand, it's the auto-form-bundle package that needs to bump its requirement and allow PHP8.0+ / Symfony6.0+ too ..

@webda2l Am I looking in the right direction ?

wdrupal commented 2 years ago

Hi

Thanks for the report. From what I understand, it's the auto-form-bundle package that needs to bump its requirement and allow PHP8.0+ / Symfony6.0+ too ..

@webda2l Am I looking in the right direction ?

Actually that means that Symfony 6 isn't supported even if PHP is ^7

webda2l commented 2 years ago

Yes indeed auto-form-bundle is blocking because not allowing SF deps |6.0, not because of PHP version '"php": ">=7.2.5"'

@wdrupal feel free to do a PR on it to fix it and the CI at the same time.

Otherwise, I will see to do the PR later, or @tchapi if you want.

tchapi commented 2 years ago

I can try tomorrow maybe !

tchapi commented 2 years ago

The PR for CI fixes (a pre-requisite to fix the dependency graph) is here for reference

tchapi commented 2 years ago

See https://github.com/a2lix/AutoFormBundle/pull/29

tchapi commented 2 years ago

Hi @wdrupal PR has been merged on master — Could you try again with requiring auto-form-bundle@dev-master ? If this works, we can create a new release on the AutoForm repository

wdrupal commented 2 years ago

Hi @tchapi

It works well for me image

tchapi commented 2 years ago

Superb! I'll tag that right away

tchapi commented 2 years ago

Fixed in https://github.com/a2lix/AutoFormBundle/releases/tag/0.4.0

wdrupal commented 2 years ago

That's great but now we should fix TranslationFormBundle itself to use this release