a2lix / TranslationFormBundle

Ease translations with some dedicated Symfony form types
https://a2lix.fr/bundles/translation-form
MIT License
330 stars 140 forks source link

Using href="#***" in tab spams browser history #389

Closed karrakoliko closed 5 months ago

karrakoliko commented 5 months ago

Environment

Composer packages

easycorp/easyadmin-bundle           v4.9.3  Admin generator for Symfony applications
symfony/framework-bundle            v6.3.4  Provides a tight integration between Symfony components and the Symfony full-stack framework
a2lix/auto-form-bundle              0.4.7   Automate form building
a2lix/translation-form-bundle       3.2.1   Translate your doctrine objects easily with some helpers

PHP version

PHP 8.1.27 (cli) (built: Mar 12 2024 05:04:18) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.27, Copyright (c) Zend Technologies
    with Xdebug v3.2.2, Copyright (c) 2002-2023, by Derick Rethans

Subject

Using href="#*" in translation tabs spams browser history with no reason. When we switch language tab it calls `history.pushState()with tab#anchor`, but actually we dont need that, as page does not re-rendering to actual tab.

If package used with easyadmin, to get back to the index page after switching language tab, we have to press *Back browser button* <- multiple times.

Steps to reproduce

Open crud page, switch language tab multiple times, press "Back" button in your browser

Expected results

Go back to the crud index page

Actual results

Url changed, but nothing on page changed actually