a2stuff / a2d

Disassembly of the Apple II Desktop - ProDOS GUI
https://a2desktop.com
272 stars 20 forks source link

Text vertically overlaps in dialogs #126

Closed inexorabletash closed 3 years ago

inexorabletash commented 5 years ago

The default font is 9px high, but dialogs use 8px spacing. This leads to clipped descenders if strings are drawn top-to-bottom.

draw_dialog_label is the biggest offender, but the Format/Erase drive selection is also afflicted.

To fix, everything needs to do proper math rather than 3 shifts.

inexorabletash commented 5 years ago

About before: image

and after: image

inexorabletash commented 5 years ago

Format/Erase before: image

and after: image

inexorabletash commented 5 years ago

Confirm before: image

and after: image

inexorabletash commented 5 years ago

Select Entry before: image

and after: image

inexorabletash commented 5 years ago

File selector:

image

(Note the overlaps in the radio buttons, and the items in the scrolling pane only get 8px each)

inexorabletash commented 4 years ago

image

Overlapping radio buttons fixed. Items in the scroll pane are still 8px tall

inexorabletash commented 3 years ago

Before:

image

After:

image

inexorabletash commented 3 years ago

Before:

image

After:

image