a2stuff / a2d

Disassembly of the Apple II Desktop - ProDOS GUI
https://a2desktop.com
275 stars 20 forks source link

The startup disk is shown all in capital letters in the "New Folder..." dialog box when the "Control.Panels" folder is directly opened from the Apple menu #466

Closed c0mmander8 closed 3 years ago

c0mmander8 commented 3 years ago

Describe the bug The startup disk is shown all in capital letters in the "New Folder..." dialog box when the "Control.Panels" folder is directly opened from the Apple menu instead of having GS/OS (ProDOS 2.5.x) filename casing applied or Apple II DeskTop case adjusting applied like when the "Control.Panels" folder is manually opened from the "Desk.Acc" folder.

To Reproduce Steps to reproduce the behavior:

  1. Start Apple II DeskTop while booted from "A2.Desktop", which is the "A2DeskTop-1.2-alpha28-en_800k.2mg" disk image,
  2. Click on the Apple menu and go to "Control Panels".
  3. The "Control.Panels" folder opens.
  4. Click on the File menu and go to File > New Folder....
  5. The startup disk is shown as "A2.DESKTOP" in the "New Folder..." dialog box instead of being shown as "A2.Desktop" like when the "Control.Panels" folder is manually opened from the "Desk.Acc" folder.

Expected behavior The startup disk should have GS/OS (ProDOS 2.5.x) filename casing applied or Apple II DeskTop case adjusting applied in the "New Folder..." dialog box when the "Control.Panels" folder is directly opened from the Apple menu like when the "Control.Panels" folder is manually opened from the "Desk.Acc" folder.

Screenshots I am sorry. I have no screenshots to help explain my problem.

System Details (please complete the following information):

Additional context There is no other context about the problem here.

inexorabletash commented 3 years ago

This would likely also apply to folders opened via the Selector menu.

inexorabletash commented 3 years ago

Screenshot for reference:

image

This due to the DeskTop path being composed using the ProDOS PREFIX, which is capitalized. I'm going to mark this as Won't Fix because this would require iterating over all parent directories to find the file entries to extract the capitalization, which would be a significant performance hit during startup for such a minor issue.

c0mmander8 commented 3 years ago

This issue does not also apply to folders opened via the Selector menu.

c0mmander8 commented 3 years ago

Why does this bug not occur when folders are opened via the Selector menu?

inexorabletash commented 3 years ago

Selector entries are created by the program, and recorded in the SELECTOR.LIST file as mixed-case at the time they are created.