search

a2stuff / a2d

Disassembly of the Apple II Desktop - ProDOS GUI
https://a2desktop.com
270 stars 20 forks source link

sound DA: Add a cancel button #775

Closed buserror closed 11 months ago

buserror commented 11 months ago

I've been debugging my own IIe emulator lately, and I used the sound DA a lot to test it... However it was always nagging me that this modal dialog lacks a... cancel button!

So I dived in, I have to say I'm very fresh to the codebase, but I tried to respect the 'style' and behaviours.

inexorabletash commented 11 months ago

Initial review looks good. I'll test when I can.

inexorabletash commented 11 months ago

Code looked good. I might tweak the layout to move the cancel button to the left so the buttons are symmetrical, but there's not a standard layout yet.

buserror commented 11 months ago

Ah I wasn't sure, I had started by putting it left, but then I remember that on old Mac's the buttons were always tucked to the right...