a4k-openproject / plugin.video.openmeta

GNU General Public License v3.0
3 stars 3 forks source link

fix for issue #8 #26

Closed diddy81 closed 5 years ago

diddy81 commented 5 years ago

fix for information not showing for Latest Releases (Trakt) and Next Episodes

drinfernoo commented 5 years ago

What information does this give us exactly?

diddy81 commented 5 years ago

Openmeta currently does not pull the plot for the latest releases list or next episodes list this will fix that

diddy81 commented 5 years ago

drinfernoo ive added default player and context menu to choose a player i also fixed the context menus showing on widgets by adding the missing meta data

drinfernoo commented 5 years ago

In coming updates, player interactions, metadata, context menus, widgets, and many other things have been fixed already. If this PR still applies after further testing of internal changes, a merge is likely.

diddy81 commented 5 years ago

Yes I have seen in the issues about 2.0 milestones but having not seen any of the items being implemented in the develop branch wasn't sure how much had been done already and the parts I have done are just things I wanted implemented and wanted to share with your guys any idea when the 2.0 update will be ready or if I can be any help getting it ready?

drinfernoo commented 5 years ago

There isn't any ETA for a future release, but I'm testing this in an effort to go ahead and merge it.

I can confirm your fixes for metadata on Latest Releases and Next Episodes are working, but using the ?extended=full argument makes it take a *very long time to load those lists.

With regards to context menus, there's still something funky going on here, as the menus inside OpenMeta have duplicated options, and the ones on widgets are still missing options.

Your implementation of default players does appear to be working smoothly for me, including the changing defaults back and forth and choosing a different option besides the set default.

If you can figure out how to get the context menus inside the add-on to not have duplicated options, I'll merge this 👍

diddy81 commented 5 years ago

Close kodi and reopen it context menus should reset and be correct

diddy81 commented 5 years ago

Yep I see the error I made with the duplicate menus in openmeta I can push a fix for that and will look at changing the full meta to reduce loading time

diddy81 commented 5 years ago

fixed the context menus however the meta data will need to stay as full as the only other level i could find documentation for does not return the plot as far as i can see

diddy81 commented 5 years ago

Hay drinfernoo just noticed you said some options are missing in the widget context menus could you tell me what's missing or is it just the 'use default player' option in a openmeta widget that is missing if it is it should be like that as just clicking the item will load the default player

drinfernoo commented 5 years ago

Try pointing a widget at a menu of TV Shows 😉

diddy81 commented 5 years ago

got openinfo showing on tv show widgets just clicking will open season view are you wanting the use/choose player items in the context menus too as it will auto play season 1 episode 1 or is just having openinfo what you want

SOOTTV commented 5 years ago

@diddy81 been testing out your changes. Love the default player, works great. One thing you fixed, not sure if you're aware; widgets using landscape layout would take a poster image and squeeze it into the landscape box, which looked terrible. You've fixed that issue but only for rows showing movies, I'm wondering if you could do the same for TV shows if you know how you did it?

diddy81 commented 5 years ago

@SoulTV no idea how i fixed that I didnt make any changes to images at all unless its just because i added the mediatype tag to movies but I'm struggling to reproduce what your describing could you tell me what skin and widget settings you are using

if it is the mediatype tag i have now added that to tv shows and will be in my next push just waiting to hear back from @drinfernoo about the tv show context menus that he would like then I will make the next update

SOOTTV commented 5 years ago

@diddy81 I'm using Bingie v1.02 by Cartman.dos as my skin. Here's the repo: https://github.com/cartmandos/repository.bingie If you change the homepage widget layout to landscape (should be the default) and add an OpenMeta widget for TV Shows and Movies, you'll definitely see what I'm talking about. I can also preconfigure the userdata file for you if that helps? I'm assuming this bug would be present across all Titan based skins. Hopefully the mediatype tag fixes that

Also, to @drinfernoo 's point about the TV Show widget, on my build at least, Movie widgets have a context menu and TV Show widgets don't have one at all

Quick question, is there a way to download the files so I can just copy and paste them in place? I've been copying the text from each one and replacing the text in the files to test stuff out

drinfernoo commented 5 years ago

@SoulTV If you go to https://www.github.com/diddy81/plugin.video.openmeta/, you can download the zip with his changes.

diddy81 commented 5 years ago

I'll take a look at the skin see what I can do

The TV show context menu will be enabled in my next push

And @drinfernoo ninjaed me lol

SOOTTV commented 5 years ago

@diddy81 The context is working great for me on tv show widgets. Whatever you did fixed the landscape/ portrait problem with my skin. Thx!

Idk if this is complicated but, is there any way you could implement a toggle in settings to flatten seasons?

SOOTTV commented 5 years ago

@diddy81 I tried to figure out how to add list but couldn't get it to work, could you add these as well?

https://trakt.tv/users/garycrawfordgc/lists/new-shows?sort=added,asc https://trakt.tv/users/enormoz/lists/netflix https://trakt.tv/users/enormoz/lists/netflix-movies https://trakt.tv/users/enormoz/lists/hulu https://trakt.tv/users/enormoz/lists/amazon

diddy81 commented 5 years ago

Sorry but I won't be adding any lists unless they have been ok'd by a main dev You can just like the lists then find them in the my trakt section

SOOTTV commented 5 years ago

Ok, I talked drinfernoo earlier about it, let me see if I can get his OK on it. I wanted to add them so that other people could use them in my build without needing my trakt account logged in or needing to like them on their account

On Jul 13, 2019, at 2:24 PM, diddy81 notifications@github.com wrote:

Sorry but I won't be adding any lists unless they have been ok'd by a main dev You can just like the lists then find them in the my trakt section

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/a4k-openproject/plugin.video.openmeta/pull/26?email_source=notifications&email_token=ALYUZ2CLZA6XGMSHPKXKEL3P7ITYPA5CNFSM4H5IBWD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ3X4RI#issuecomment-511147589, or mute the thread https://github.com/notifications/unsubscribe-auth/ALYUZ2FO3SKSQKK5GCN7OSTP7ITYPANCNFSM4H5IBWDQ.

drinfernoo commented 5 years ago

There's a good reason we don't have many user lists as main sections in the add-on. If any of those lists ever goes down, the user closes their account, or something similar, it'll break the add-on.

The only reason Latest Releases is included is because the development team has been in contact with the curator of that list (and many others), and believe it is a fairly stable arrangement.