a4k-openproject / plugin.video.openmeta

GNU General Public License v3.0
3 stars 3 forks source link

Support current undocumented API change from TVDB. #51

Closed ruinernin closed 4 years ago

ruinernin commented 4 years ago

Support both the old files contained in the zip and the new files in case this goes back to being "correct".

SerpentDrago commented 4 years ago

@ruinernin Thanks for the code man , @bg-22 you to for the modifications . with this changes we dont' need your other pr also right ?

@ruinernin Everything seems to work with your code and bg-22 's changes , just wanted you to review the changes before i merge and push to repo

bg-22 commented 4 years ago

Correct. With the changes I requested for @ruinernin 's code, my PR isn't needed. However, @ruinernin makes a good point about making this change broader, allowing it to withstand other empty variables in the future. Not a bad idea considering how TheTVDB has a track record of breaking things like this. I believe PR #53 addresses this.

drinfernoo commented 4 years ago

I cherry-picked this into develop... didn't realize it didn't close 😆