search

a4k-openproject / script.module.openscrapers

OpenScrapers Project
GNU General Public License v3.0
102 stars 40 forks source link

More Py3 changes #145

Closed Tikipeter closed 4 years ago

Tikipeter commented 4 years ago

I was hoping after this pull request Openscrapers would work in Python 3. Unfortunately, that is not the case yet.

All scrapers have been (hopefully) fixed to work with Py2/3, and some other changes needed in the modules has been done.

The main problem now is, I think, client.py, which has some old urllib2 functions that don't seem to be working when using the new urllib.request for Python 3.

I'll need more time, and possibly help from someone better than me, to sort out these issues.

addon.xml updated version to 0.0.2.007 changelog also updated.

I've tested this still works in Py2, so hopefully it doesn't cause any troubles. It would be nice, however, for others to test before pushing the update to the main branch.

host505 commented 4 years ago

The main problem now is, I think, client.py, which has some old urllib2 functions that don't seem to be working when using the new urllib.request for Python 3.

I also didn't have luck with it while converting my add-on using six. Have you tried using requests for the initial fetching? A couple scrapers used it in the past - maybe some still do.