a514514772 / DISE-Domain-Invariant-Structure-Extraction

Pytorch Implementation -- All about Structure: Adapting Structural Information across Domains for Boosting Semantic Segmentation, CVPR 2019
GNU General Public License v3.0
145 stars 25 forks source link

pytorch version and results reproduction #9

Open drazellan opened 4 years ago

drazellan commented 4 years ago

Hi Thanks for your code! I trying to reproduce the result in the paper but i get at best 42.4 miou with a batch size of 2 on a P6000 nvidia card with your default setting.

By the way one's needs a card with at least 20Gb of memory to run your code, i try on a card with 16 Gb and i got a memory issue...

I use pytorch 1.2 and i see that you used pytorch 0.3.1 so maybe it's the reason for the performances degradation as i know there is a difference in the default behaviour in upsample between those 2 versions. Have you try to re run the code with a newer version of pytorch than the 0.3.1? Thanks

a514514772 commented 4 years ago

No, we only try our code on 0.3.1. If my memory serves me well, there is a difference between 0.3.1 and 0.4.1 such that the code behaves differently in terms of accuracy and memory usage.

Unfortunately, I do not have available machines to test it for now. But, please feel free to point out problems or consider a PR.

drazellan commented 4 years ago

Thanks for your reply I just lauch a learning with modification in upsample to use align_corners=True like in the 0.3.1 version


De : Hui-Po Wang notifications@github.com Envoyé : mercredi 11 décembre 2019 09:58 À : a514514772/DISE-Domain-Invariant-Structure-Extraction DISE-Domain-Invariant-Structure-Extraction@noreply.github.com Cc : drazellan drazellan@hotmail.com; Author author@noreply.github.com Objet : Re: [a514514772/DISE-Domain-Invariant-Structure-Extraction] pytorch version and results reproduction (#9)

No, we only try our code on 0.3.1. If my memory serves me well, there is a difference between 0.3.1 and 0.4.1 such that the code behaves differently in terms of accuracy and memory usage.

Unfortunately, I do not have available machines to test it for now. But, please feel free to point out problems or consider a PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/a514514772/DISE-Domain-Invariant-Structure-Extraction/issues/9?email_source=notifications&email_token=AJGN4N4EKO6XEWFC7BJTPWLQYC2TVA5CNFSM4JZLHGA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGSRIQY#issuecomment-564466755, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJGN4N7CR7FRNCL5RXSH63DQYC2TVANCNFSM4JZLHGAQ.

huitangtang commented 4 years ago

@drazellan Hi, what's your result? I found that using align_corners=True produced a similar result. And when I run the code on two 2080Ti cards with 11 Gb, the result of miou degrades to <40%. Is it normal? Thank you for your response!