a6smile / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Add wiki page for all config options #200

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
It would be nice if /min/lib/Minify/Controller/MinApp.php
around line 110 where there is:
$path = $_SERVER['DOCUMENT_ROOT'] . $base . $file;

it would instead pick a config var or use some sort of plug-in check for path 
definition, for example:
$path = (defined('MINPATHOVERWRITE') ?  MINPATHOVERWRITE : '') . $base . $file;

Original issue reported on code.google.com by El.Nego on 26 Oct 2010 at 11:15

GoogleCodeExporter commented 9 years ago
if I missed a config setting please accept my apologies.

Original comment by El.Nego on 26 Oct 2010 at 11:16

GoogleCodeExporter commented 9 years ago
If you set $min_documentRoot, it actually changes $_SERVER['DOCUMENT_ROOT'] to 
it. So it effectively does what you want, but in a confusing and poorly 
documented way. If I can easily make this clearer in the code for 2.1.4 I'll 
try, but 2.2 will change a lot of this.

TODO: Create a wiki page for all the config options. It's not sufficient to put 
all that info only in the config.php file.

Original comment by mrclay....@gmail.com on 27 Oct 2010 at 10:53

GoogleCodeExporter commented 9 years ago
Thanks a lot mrclay.org think I got it working like I wanted now :) 

Much appreciated all your time and effort into this project

Original comment by El.Nego on 28 Oct 2010 at 3:34

GoogleCodeExporter commented 9 years ago
Thanks a lot mrclay.org think I got it working like I wanted now :) 

Much appreciated all your time and effort into this project

Original comment by El.Nego on 28 Oct 2010 at 3:34