Why need to get the dtd file by visiting http://cobertura.sourceforge.net ?

a7ex / xcresultparser

Parse the binary xcresult bundle from Xcode builds and testruns

MIT License

98 stars 28 forks source link

Why need to get the dtd file by visiting http://cobertura.sourceforge.net ? #19

Closed kieoo closed 1 year ago

kieoo commented 1 year ago

If the cobertura.sourceforge.net server is down, the tool will fatalError Why not back up a local dtd file to avoid this problem ? @fadookie

https://github.com/a7ex/xcresultparser/blob/205604b04a684ef7c6026e01f02efffc8d9987db/Sources/xcresultparser/CoberturaCoverageConverter.swift#L46

fadookie commented 1 year ago

This is working fine for me and seems to be a common practice when referencing a DTD. You are welcome to make a PR to use a cached copy of the DTD if you want.

a7ex commented 1 year ago

I made 1.4.2 with this change. Just because I tend to avoid fatalError()