Closed spetrey closed 1 year ago
@a7medev great feedback on the PR! Much appreciated. I addressed your comments and went a little further to do some additional cleanup. I also figured I would rename the language
param to script
here because it's based on Script names instead of Language names. See this table from ML Kit's text recognition v2 docs:
https://developers.google.com/ml-kit/vision/text-recognition/v2/languages#supported-langs
Let me know if you see anything else that needs addressing :)
Thanks for the last bit of feedback on changes @a7medev π
@spetrey I think will also need to support for Android as well to keep both platforms consistent. What do you think?
@a7medev apologies on the delay getting back to you. I do agree that supporting Android is important. Unfortunately, I have never worked on any Java projects before this, so I may be unable to contribute to supporting Android on this PR (in the short-term) π
What're your thoughts on merging this PR, then creating an Issue to track adding support for TextRecognition
on Android at a later date?
@spetrey Sounds good. Thanks for your contribution! π I'll test this PR on iOS and merge it and will work on another PR for Android.
Thank you for taking the time to review! Let me know if you encounter any issues testing @a7medev, happy to resolve anything that comes up π
Happy to contribute friend. Also, thanks for the feedback on this PR @a7medev! Appreciate you double-checking my contribution and ensuring backward compat on Android as well π
Hi @a7medev and @spetrey , Just checking in to see if Android support for non-latin has been added or if you've started on that MR @a7medev ? It's something needed before I can ship my product as there are a ton of android users in South Korea. Would love any help, happy to sponsor!
Hi @cardanoeconews! Unfortunately, I haven't had much time to work on adding Android support lately, will work on it once I have some time. ππΌ Happy to know you are using it in production!
I don't have GitHub Sponsors set up at the moment, but I'm working on itβhaving some support would actually allow me to spend more time working on these projects and delivering more features.
Wow, that was fast! π I've set up GitHub Sponsors, you can sponsor my work on React Native ML Kit and other packages through my Sponsors page!
Quick update! Non-Latin script Android support just landed in @react-native-ml-kit/text-recognition
v1.5.0 π
Closes #27
What does this PR do?
This PR adds official text-recognition support for:
How to use
Results:
Japanese and Devanagari
Chinese
Korean
This is my first PR here! I will be the first to admit that Objective-C is not my strongest language, so I welcome any and all feedback! I would love for someone to pull this branch down and take it for a spin. My initial testing yielded some good results but would love someone to double-check my work and give me a sanity check π