search

a7medev / react-native-ml-kit

React Native On-Device Machine Learning w/ Google ML Kit
MIT License
358 stars 55 forks source link

Barcode scan #3

Closed s0rta closed 2 years ago

s0rta commented 2 years ago

added a minimal barcode scan implementation using the image labeling implementation as a framework. I've got it up on npm under barcode-scanning right now (username notyet) but wanted commit here as you have a great organizational structure to the mlkit implementations. Right now it just scans all barcodes, and returns an array of objects containing the value and the type of barcode. should be working for android and iOS. If there are any changes needed I'm down to work on them, just let me know.

a7medev commented 2 years ago

Can you add an example app to it? To make it easier to test the package you added. You can copy an example app from any of the other modules in the repo and apply the changes needed.

a7medev commented 2 years ago

We need TypeScript types, you can add them in an index.d.ts file in the package root specifying the types the package uses, feel free to use other .d.ts files in the project as a reference. Also, returning the frame where the barcode is found (which is returned by the native MLKit SDK) is a thing to consider. You can use face-detection package as a reference.