Closed vonovak closed 11 months ago
Hi @vonovak! Thanks a lot for your contribution. I have a concern though, I think Google ML Kit for Text Recognition on iOS is at version 4 currently, do you have a reason not to pick the latest?
Hello! I picked the version from here: https://developers.google.com/ml-kit/vision/text-recognition/v2/ios
If there's v4, I haven't seen it? (Do you see it?) Thanks 👍
@vonovak Yeah, I checked that page and couldn't see it as well, but looks like v4 is out (some mentions of it are in #24). Let's upgrade to the latest then to keep the package up-to-date. 🙏🏼
@a7medev done! :)
I just came here to ask about updating to the MLKit pods - I had updated my podspec locally to the v4.0, and they perform much better than the v2.6. Excited to see this merged & released!
Thank you! 👍
this:
1) updates the deps 2) on Android,
getCornerPoints()
is marked as Nullable so I took a safer approach like it's done withgetBoundingBox()
3)cornerPoints?: CornerPoints;
is a more specific type, because there are always going to be 4 items in the arrayIf you merge this and release, please be so kind and push the version bump commit and the git tag (
npm version minor
produces those) in the repo so that they are in the git history, thank you! :)