search

a7medev / react-native-ml-kit

React Native On-Device Machine Learning w/ Google ML Kit
MIT License
342 stars 55 forks source link

Update podspecs + fix TextRecognition #5

Closed catalinmiron closed 2 years ago

catalinmiron commented 2 years ago

Since there were differences between GoogleMLKit version, there was no way to use TextRecognition and FaceDetection on the same project.

a7medev commented 2 years ago

Hi @catalinmiron, Thanks for the contribution! I was wondering why not update all GoogleMLKit iOS dependencies' versions not only Face Detection, Text Recognition and Image Labeling?

a7medev commented 2 years ago

I'll merge and resolve other related issues in another PR. Thanks for the contribution @catalinmiron!

catalinmiron commented 2 years ago

Hi @a7med-mahmoud, I am very sorry but I somehow missed you comment from above (maybe got lost in my inbox). I have created the PR only for these packages because this is what I'm using in the project kinda. Sorry for the confusion :(

a7medev commented 2 years ago

No problem. Thanks for the contribution! I did upgrade all native dependencies and added the other languages to Text Recognition's Android too.