search

a8m / angular-filter

Bunch of useful filters for AngularJS (with no external dependencies!)
https://github.com/a8m/angular-filter
MIT License
2.93k stars 331 forks source link

Change to different angular2 repo #240

Closed danrevah closed 7 years ago

danrevah commented 7 years ago

Related to our previous conversation. WDYT? anything you think is missing in: ng-pipes before changing it?

sesubash commented 7 years ago

How to do filterBy ?

a8m commented 7 years ago

Changing ng-pipes to danrevah/ng2-pipes was something I thought about. The reason for that was that ng-pipes started as a copy-paste project of angular-filter (mostly via code), and it was unstable at the start.

We tried danrevah/ng2-pipes but we found too many discrepancies between the projects (for example: first and last), and also, some of the filters were missing (filterBy is good example).

I decided to stay with ng-pipes, and right now it's almost stable. In the current roadmap I'm planing to add all the remaining filters from angular-filter (the boolean filters), add the filterFilter from angular-1, and improve performance.

I'm gonna close this PR, and I appreciate your help. TY.

danrevah commented 7 years ago

It's possible to take care of that discrepancy. I can take take effort on my own and to make that adjustments. It depends if you really want to lay out the differences that you think are necessary and I will take care of them. WDYT?