search

a914-gowtham / android-video-trimmer

Helps to trim local videos with compress option on Android applications using Exoplayer 2 and FFmpeg.
Other
362 stars 115 forks source link

Translation required for "Edit Video" title in video editor. #22

Closed pranishres closed 3 years ago

pranishres commented 3 years ago

I have been using this library and found it as the best one for development and support from you guys. However, I have 1 change request.

My app is multilingual and when I build it in Japanese, the title of the video editor is still "Edit Vide" which is hardcoded in ActVideoTrimmer class. Could you migrate the hardcoded texts to strings file so that I can add translations for other languages as well?

a914-gowtham commented 3 years ago

Ok..will be added for the next release

pranishres commented 3 years ago

Ok..will be added for the next release

Thank you. How long will it take for the next release? I am in need of it in a day or two. So can I just copy all the library code to my project? Do I have your permission?

a914-gowtham commented 3 years ago

Sure...you can use it or else you can even make a pull request

pranishres commented 3 years ago

Sure...you can use it or else you can even make a pull request

Hello again. I would be glad if you could you do a quick fix and update the library by adding the hardcoded text to strings.xml file? I have released my app to playstore and don't want to take risk by manually adding all your code.

a914-gowtham commented 3 years ago

I just made a release.Use that

pranishres commented 3 years ago

Thank you. You are the best. You are the one who have provided me this much support in GitHub till now.