search

a914-gowtham / android-video-trimmer

Helps to trim local videos with compress option on Android applications using Exoplayer 2 and FFmpeg.
Other
362 stars 115 forks source link

Seekbar need to be locked in the Max duration while using with Min to Max TrimType #28

Open Equin opened 3 years ago

Equin commented 3 years ago

Hi, can you say when this pull request (Added Max Duration #27) will be released ? And did i undesrstand it right. if i will set 10s max duration then users will be able to cut videos up to 10 sec and less ?

a914-gowtham commented 3 years ago

yeah, you are right. I need to check again the pull request. If everything is ok, I will make a release by 2 days

a914-gowtham commented 3 years ago

Min to a max feature already available in this lib refer readme for other trim types.

TrimVideo.activity(videoUri)
          .setTrimType(TrimType.MIN_MAX_DURATION)
          .setMinToMax(0, 30)  //seconds
          .start(this);
Equin commented 3 years ago

@a914-gowtham, Oh, i see, but can it be possible to lock that area like with min duration? Right now (min set 10s, max set 5 mins.), when i am moving that seek bar selector to less than 10 seconds - both selectors moving avoiding me to select less then 10 s, but for max duration it is not moving, and i can move it like i want, just Done button becomes not clickable. For users it is not very user friendly

a914-gowtham commented 3 years ago

Hi @Equin, Now I understand your issue. I felt the same from the beginning. I've used crystal-seekbar as a trimming duration controller which has no option to help with our case. I need to change the seekbar library. I will try to make the seekbar change Asap and this #27 is a fix of a minToMax bug not for max duration issue.

hsinha76 commented 2 years ago

Is this issue solved? @a914-gowtham