search

a914-gowtham / android-video-trimmer

Helps to trim local videos with compress option on Android applications using Exoplayer 2 and FFmpeg.
Other
362 stars 115 forks source link

Storage permission is missing toast message on Android 11 #38

Closed qwaskhaled closed 3 years ago

qwaskhaled commented 3 years ago

I can't trim the video because WRITE_STORAGE_PERMission always returns false.

qwaskhaled commented 3 years ago

You may consider context.getExternalFilesDir() because writing to it doesn't need permission

a914-gowtham commented 3 years ago

Hey @qwaskhaled besides this storage issue current version of the library a issue on release build because of the dependent library. consider using https://github.com/a914-gowtham/videotrimmer this repo and read the updated readme of this library. sorry for the inconvenience

a914-gowtham commented 3 years ago

You may consider context.getExternalFilesDir() because writing to it doesn't need permission

I've worked on this storage issue in the new repository that I mentioned above. I will check your suggestion and update that new repository soon

a914-gowtham commented 3 years ago

https://github.com/a914-gowtham/videotrimmer

qwaskhaled commented 3 years ago

I tried it and it's NOT fixed. Also, The new repo is very difficult to be set up so I would really appreciate it if you can fix it in this repo.

a914-gowtham commented 3 years ago

@qwaskhaled can you try now I just worked on changes in both library, that new repo and made a release implementation 'com.github.a914-gowtham:Android-video-trimmer:1.5.11'

The release build issue occurs because of using aar file(mobile-ffmpeg) inside of aar(android-videotrimmer library) file . I can't publish the release on jitpack. it throws build error. I will try to find any workaround asap

qwaskhaled commented 3 years ago

Yes, it's working now. Thank very much for your assistance and I do appreciate your fast response.

a914-gowtham commented 3 years ago

@qwaskhaled use can use the latest release that release build issue has been resolved now.