search

a914-gowtham / compose-ratingbar

ratingbar composable for jetpack compose :rocket::star2:
MIT License
240 stars 21 forks source link

Problem with Modifier.pointerInput #39

Open ITmind opened 1 year ago

ITmind commented 1 year ago

Not use pointerInput(Unit), It captures the lambda with all the variables inside. Use, for example, pointerInput(onValueChange). I spent a day trying to figure out why the new version stopped selecting ratings in some cases.

Description of a similar problem: https://stackoverflow.com/questions/70849243/listeners-inside-detecttapgestures-only-ever-get-the-first-variable-value-othe

a914-gowtham commented 1 year ago

@ITmind will fix this. a PR would be helpful if possible

a914-gowtham commented 1 year ago

https://github.com/a914-gowtham/compose-ratingbar/pull/40 @ITmind can u check this

ITmind commented 1 year ago

40 @ITmind can u check this

yes, this ok