Added a changelog feature

aEnigmatic / xcom2-launcher

Unofficial XCOM 2 launcher

GNU General Public License v3.0

0 stars 0 forks source link

Added a changelog feature #3

Closed robojumper closed 8 years ago

robojumper commented 8 years ago

The changelog feature crawls through the steam website and gets the changelog, with html tags filtered out.

robojumper commented 8 years ago

Nah, i somehow borked the export feature. Please double-check what went wrong.

BlueRaja commented 8 years ago

Most mods do not even use the changelog, and a user may have a lot of mods, so making a web request for every mod every time UpdateModInfo() is called is a huge overhead.

Instead it should:

Only make the web-request when the user actually switches to the 'changelog' tab
Cache the request so the changelog is only requested once per mod.

The lifetime of this application is short-lived, so there's probably no reason to ever update the cache.

robojumper commented 8 years ago

Gonna close the pull request and rework the code as well as figure out why the export feature broke.