search

aEnigmatic / xcom2-launcher

Unofficial XCOM 2 launcher
GNU General Public License v3.0
0 stars 0 forks source link

Added a changelog feature #4

Closed robojumper closed 8 years ago

robojumper commented 8 years ago

With help from BlueRaja. Visual Studio reordered the lines in MainForm.Designer.cs, hence the deletions.

BlueRaja commented 8 years ago

Other than the small suggestions above, looks good, nice job!

(Since you said you're new to Github:) You can push any additional changes to your branch and they'll get reflected automatically, you don't need to open a new PR.

robojumper commented 8 years ago

How does this ContinueWith() thing work? Setting the textbox text via changelog.Result causes a System.InvalidOperationException because the access occurred from a different thread?

BlueRaja commented 8 years ago

Oh, right, derp. You'll either have to call Invoke on the control, or use await instead of ContinueWith. I'd say do the latter, it's simpler.

More on Invoke: http://stackoverflow.com/questions/14703698/invokedelegate

aEnigmatic commented 8 years ago

Hey, thanks for the PR!

1 very minor thing: Can you change the namespace in ModChangelogCache to XCOM2Launcher.Mod (- Classes).

BlueRaja commented 8 years ago

LGTM! :+1: