search

aFarkas / html5shiv

This script is the defacto way to enable use of HTML5 sectioning elements in legacy Internet Explorer.
http://paulirish.com/2011/the-history-of-the-html5-shiv/
9.89k stars 2.56k forks source link

Simplify print-shiv by simply wrapping HTML5 elements instead #42

Closed jdalton closed 12 years ago

jdalton commented 12 years ago

Simplify print-shiv by simply wrapping HTML5 elements instead of completely swapping them out.

jdalton commented 12 years ago

I checked the one unit test we have but I would like more tests to see if this is a safe solution. Instead of replacing the HTML5 element with the namespaced element and moving the children of the HTML5 element into the namespaced element.... I'm simply wrapping the HTML5 element with the namespaced element.

aFarkas commented 12 years ago

What unit test do you mean (simplified jQuery tests)? For the print part we currently only have functional/visual test. Those tests are all fine with your changes.

jdalton commented 12 years ago

I meant adding more than just the mixed-test.html test (though I guess it's several tests in one file).