search

aFarkas / html5shiv

This script is the defacto way to enable use of HTML5 sectioning elements in legacy Internet Explorer.
http://paulirish.com/2011/the-history-of-the-html5-shiv/
9.89k stars 2.56k forks source link

Cleanup IE browser crash fix #45

Closed jdalton closed 12 years ago

jdalton commented 12 years ago

Cleanup IE browser crash fix

aFarkas commented 12 years ago

I have already started to clean this up. I'm not 100% happy with this. But I really need some more time to think about this in general. Currently, I think, we have should make shivMethods as an opt-in and not as an opt-out... :-(

jdalton commented 12 years ago

I have already started to clean this up.

Sure, but your cleanup is without understanding (why the regexp exists in the first place) and also has tag names in the regexp that are unnecessary (like optgroup). I started this cleanup commit before your commit so will merge to make it easier to apply.

jdalton commented 12 years ago

I'm not 100% happy with this. But I really need some more time to think about this in general. Currently, I think, we have should make shivMethods as an opt-in and not as an opt-out... :-(

Yap! I am totally for opting in instead of opting out.

jdalton commented 12 years ago

This pull request also includes a unit test.