aFarkas / webshim

[DEPRECATED] Webshims Lib is a modular capability-based polyfill-loading library
http://aFarkas.github.com/webshim/demos/index.html
MIT License
1.42k stars 201 forks source link

Prevent implicit return of window.URL function #576

Closed outdooricon closed 8 years ago

outdooricon commented 8 years ago

This prevents the implicit return of window.URL's constructor instead of a simple boolean value for usermedia-core's test. This is important because the polyfiller looks to see if test is a function, and if so calls it. The recently released Chrome 53 doesn't allow direct calls to the URL constructor anymore and will throw an error if called directly. So now a lot of people are seeing webshim break and the further load of their JS stack halt.

It looks like the call to URL's constructor has been occurring for a little while now but was hidden because the existence of window.URL is still being verified, even though it was also being erroneously called.

pherris commented 8 years ago

👍

eraserqueen commented 7 years ago

Can we get this fix in a new release please?

aFarkas commented 7 years ago

@eraserqueen I will do so. Give me this weekend.