aHub-Tech / Live-Divulgador

Divulgador de Twitch streams no Twitter
https://livedivulgador.herokuapp.com/
GNU General Public License v3.0
11 stars 3 forks source link

Spike: Pesquisar possibilidade de utilizar MariaDB #9

Closed vcwild closed 2 years ago

vcwild commented 3 years ago

Poderia ser aberta uma issue para analizar a viabilidade de trocar o postgres pelo mariadb para que não possuam mais dependencias como a "libpq-dev"

Originally posted by @chrisemke in https://github.com/aHub-Tech/Live-Divulgador/pull/6#pullrequestreview-776713178

chrisemke commented 3 years ago

There is an official doc from the mariadb team with sqlalchemy and docker, I think that if it decides to be applied, we will have less problems in containerizing the application and easier integration since it is a much more community friendly project mariadb+sqlalchemy+docker

RodrigoDornelles commented 2 years ago

Poderia ser aberta uma issue para analizar a viabilidade de trocar o postgres pelo mariadb para que não possuam mais dependencias como a "libpq-dev"

Originally posted by @chrisemke in #6 (review)

qual seria o problema em questão com a dependência sob "libpq-dev" ?

chrisemke commented 2 years ago

@RodrigoDornelles When we are going to containerize the code we have to install this lib so that the orm can talk to the database, this makes the containerization process difficult because the slim images don't come with enough to install it. After a lot of research we saw that mariadb also needs a lib but we were able to install it in containers with slim images like this:

RUN apt-get update \
     && apt-get -yy install --no-install-recommends gcc libmariadb-dev \
     && pip3 install -r ./app/requirements.txt \
     && apt-get -y remove --purge --auto-remove gcc

Another good advantage is that we will use the official mariadb library to connect to orm.

RodrigoDornelles commented 2 years ago

Entendi, faz sentido. Não tenho mais nenhuma objeção.

Voce esta de acordo @ttiagojm ?

ttiagojm commented 2 years ago

Estou de acordo sim.