Ktor 2.0 support - Githubissues

aPureBase / KGraphQL

Pure Kotlin GraphQL implementation

https://kgraphql.io

MIT License

298 stars 58 forks source link

Ktor 2.0 support #175

Closed joreilly closed 1 year ago

joreilly commented 2 years ago

I realise Ktor 2.0 is still in eap right now but just curious if there's know changes needed/planned to support it? I tried to update a project I have here to use Ktor 2.0 (using v0.17.14 of the library) but getting following

Type mismatch.
Required:
RouteScopedPlugin<TypeVariable(B), TypeVariable(F)>
Found:
GraphQL.Feature

joreilly commented 2 years ago

Just fyi that Ktor 2.0 is beta now so likely will see more projects starting to use it.

sangeetds commented 2 years ago

Need to change types, would like to undertake this change.

NathanPB commented 2 years ago

it makes me pretty worried because @jeggy seems not to be around to address this change

sangeetds commented 2 years ago

@NathanPB check again, @jeggy is still active I guess.

sangeetds commented 2 years ago

Created #179. It should add support for Ktor 2.0

NathanPB commented 2 years ago

@NathanPB check again, @jeggy is still active I guess.

Yes, I was getting worried because he used to be very active here and suddenly disappeared

ronjunevaldoz commented 2 years ago

is this still active?

berserkore commented 2 years ago

Hey People,

If you are looking to support this library with Ktor 2.0, I made a comment and temporary fix to support Ktor 2.0 until this library get revived.

https://github.com/aPureBase/KGraphQL/issues/185

Cheers

sangeetds commented 2 years ago

Hey @berserkore @ronjunevaldoz @NathanPB @joreilly and everyone else. I had already raised a PR #179 for fixing this but I guess the owner is currently inactive now. I have forked this library where the particular commit is there and I have tested it for very basic cases and was seem to be working. Didn't get much time before to properly maintain it but I think from now I can maintain it since I have a use for it in my personal project too. Would love to get feedback and will plan to actively maintain it soon.

jeggy commented 2 years ago

Hi all. Sorry for being inactive for such a long time.

I will start being active in this community again and I have now opened GitHub discussions and opened a discussion about getting more maintainers on this project (#187).

We want to keep this repository active and maintain the maven repository and the https://KGraphQL.io/ website.