search

aRTy42 / POE-ItemInfo

Item Info Script for Path of Exile
166 stars 224 forks source link

[BUG] Pseudo calculated for unique map #35

Closed byg0n3 closed 7 years ago

byg0n3 commented 7 years ago

Subj map_pseudo

aRTy42 commented 7 years ago

Did you use the script on another item shortly before the map that had +25% total ele res? It might be a case where the data was not properly reset.

Eruyome commented 7 years ago

That's very possible, I should have reset all data correctly on TradeMacro, not so sure about that on ItemInfo.

aRTy42 commented 7 years ago

I can't reproduce it though.

dein0s, if you still have that map, does the pseudo mod always show up? In case it does not, can you remember what you did before or even manage to figure out a certain sequence that causes it?

byg0n3 commented 7 years ago

Okay, right now it does not show up. It happened too late at night and before the patch, so I can not truly remember steps to reproduce it. I'll try few things, but no promises here. Guess it was just temporary cache issue or smth like this.

byg0n3 commented 7 years ago

Still randomly getting this 'pseudo' on different items, no exact steps to reproduce yet. gem_pseudo helmet_pseudo

4GForce commented 7 years ago

I managed to reproduce it with the following :

Problem solved by resetting Item.Implicit in ParseItemData method ( Item.Implicit := "" )

aRTy42 commented 7 years ago

Thank you. In hindsight that was a pretty stupid mistake to overlook since there was another issue with implicits before.

4GForce commented 7 years ago

Btw, the Item class doesn't even initialize hasImplicit and Implicit attributes. Building an Item.Reset() method might be the way to go, both for ParseItemData and the Item class constructor.

You guyz need a contributor ?? I'm trying to learn AutoHotKey while working on my c++ skills and my poe builds. I have some spare time, let me know.

aRTy42 commented 7 years ago

I am taking care of the script because no one else wanted to when the last person stepped down and I didn't want to see such a helpful tool become outdated. At the moment I am also mostly keeping it working than developing new things. The last few major functionality updates are all from Eruyome, because he is actively working on the TradeMacro.

If you want to contribute, please do.

4GForce commented 7 years ago

Not sure how this is suppose to work but I can't send pull request. I guess you need to add me to repo somehow.

aRTy42 commented 7 years ago

You fork the repository, make changes to your copied version and then send a pull request.

4GForce commented 7 years ago

Says I don't have authorization, pull request are working on my personal repo so it can't be network related. But no stress, don't waste your Saturday night.

pull request failed

4GForce commented 7 years ago

nvm, I deleted everything and started over, now it works