search

aRTy42 / POE-ItemInfo

Item Info Script for Path of Exile
167 stars 225 forks source link

Unprocessed mods #48

Closed 4GForce closed 7 years ago

4GForce commented 7 years ago

This commit looks like shit but its just some comments and a big IF{}ELSE{}. Simply checking for empty affix lines while forming the tooltip. Mod showed as : " ? Unprocessed Essence Mod or Unknown Mod ? "

I'm kinda new to github, let me know if something is wrong with my pull requests, thank you !

aRTy42 commented 7 years ago

I'm not sure why the whole revert and revert-revert commits get included. There should be a method to handle that better, but I also only started using GitHub half a year ago for the script, so I can't tell how to avoid that.

4GForce commented 7 years ago

Yeah I couldn't figure a way to undo, remove or not commit that double revert, sorry about that. I'll redo my branching also, something is messed up, I ended up having multiple branches on my desktop and they were accessing the same files.

Eruyome commented 7 years ago

There's the command squash https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/, Github gives you the option to use it when you merge pull requests. @aRTy42 try using it.

Here's an example of such a merge https://github.com/PoE-TradeMacro/POE-TradeMacro/commit/1587c9086b9c75332c5c20eaa0949ea6f76aeb94, it shows as 1 commit in the commit history but you can view all commit messages.